Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pay): add galoy pay #3618

Merged
merged 7 commits into from
Dec 1, 2023
Merged

feat(pay): add galoy pay #3618

merged 7 commits into from
Dec 1, 2023

Conversation

UncleSamtoshi
Copy link
Contributor

No description provided.

apps/pay/components/Layouts/AppLayout.tsx Fixed Show fixed Hide fixed
apps/pay/components/Layouts/AppLayout.tsx Fixed Show fixed Hide fixed
newCurrency === "SATS" ? Math.round(usdToSats(amount)) : satsToUsd(amount)

router.push(
getUpdatedURL(router.query, { currency: newCurrency, amount: newAmount, display }),

Check warning

Code scanning / CodeQL

Client-side URL redirect Medium

Untrusted URL redirection depends on a
user-provided value
.
Untrusted URL redirection depends on a
user-provided value
.
}

const handleAmountUpdate = useDebouncedCallback(({ numberValue }) => {
router.push(getUpdatedURL(router.query, { amount: numberValue }))

Check warning

Code scanning / CodeQL

Client-side URL redirect Medium

Untrusted URL redirection depends on a
user-provided value
.
Untrusted URL redirection depends on a
user-provided value
.
@UncleSamtoshi UncleSamtoshi marked this pull request as ready for review November 30, 2023 19:34
@UncleSamtoshi UncleSamtoshi changed the title feat: add galoy pay feat(pay): add galoy pay Nov 30, 2023
<ul className={`${openSideBar && styles.nav_menu_bg} ${styles.nav_menu}`}>
<li>{`Ways to pay ${username ?? "user"} `}</li>
<li onClick={closeSideBar}>
<Link href={cashRegisterLink}>

Check warning

Code scanning / CodeQL

Client-side URL redirect Medium

Untrusted URL redirection depends on a
user-provided value
.
</Link>
</li>
<li onClick={closeSideBar}>
<Link href={payCodeLink}>

Check warning

Code scanning / CodeQL

Client-side URL redirect Medium

Untrusted URL redirection depends on a
user-provided value
.
Copy link
Contributor

@vindard vindard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a commit with some Tiltfile additions to have pay be available for the integration github action and for when we bring up the monorepo with buck2 run //dev:up

There's some other small changes as well that we might need to make

.github/labeler.yml Outdated Show resolved Hide resolved
@@ -0,0 +1,42 @@
# Install dependencies only when needed
FROM node:20-alpine AS deps
Copy link
Contributor

@vindard vindard Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Dockerfile can probably be redone similar to ones in app/dashboard and apps/consent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will address in a follow up pr

apps/pay/docker-compose.yml Outdated Show resolved Hide resolved
@UncleSamtoshi UncleSamtoshi merged commit d2e95df into main Dec 1, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants