-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: initial Tiltfile #3412
chore: initial Tiltfile #3412
Conversation
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
6464023 | Generic Private Key | 8f0f787 | dev/config/fulcrum/tls.key | View secret |
7593115 | Elliptic Curve Private Key | 86cb4de | dev/config/lnd/tls.key | View secret |
7652397 | Generic High Entropy Secret | de79369 | .env | View secret |
7652397 | Generic High Entropy Secret | 6c7c422 | .env | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
cf0ffaf
to
4cdb27b
Compare
3784e38
to
ee64b8e
Compare
d9b0bcd
to
2730d3b
Compare
@@ -0,0 +1,34 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make to look into terraform so we have some parity with prod, instead of having a script? or that would not make sense for dev?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO too much overhead to bring in another tool for dev.
ec14258
to
189c941
Compare
189c941
to
b829347
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Local workflows work, and I can see how we might tailor this to be able to run integration/bats test against soon
@@ -0,0 +1,19 @@ | |||
rpcuser=rpcuser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the intention to eventually remove these files from core/api/dev
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
Running:
Will bring up tilt and starts the core / auth stack - enough to be able to develop the consent app and run its integration tests on top of it.
To verify integration tests you can either click on the
consent-test
resource in the tilt panel or run:once the whole tilt file is running.