Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: initial Tiltfile #3412

Merged
merged 10 commits into from
Oct 26, 2023
Merged

chore: initial Tiltfile #3412

merged 10 commits into from
Oct 26, 2023

Conversation

bodymindarts
Copy link
Member

@bodymindarts bodymindarts commented Oct 23, 2023

Running:

buck2 run //dev:up

Will bring up tilt and starts the core / auth stack - enough to be able to develop the consent app and run its integration tests on top of it.

To verify integration tests you can either click on the consent-test resource in the tilt panel or run:

buck2 test //apps/consent:cypress

once the whole tilt file is running.

@gitguardian
Copy link

gitguardian bot commented Oct 23, 2023

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
6464023 Generic Private Key 8f0f787 dev/config/fulcrum/tls.key View secret
7593115 Elliptic Curve Private Key 86cb4de dev/config/lnd/tls.key View secret
7652397 Generic High Entropy Secret de79369 .env View secret
7652397 Generic High Entropy Secret 6c7c422 .env View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@github-actions github-actions bot added the ci label Oct 23, 2023
@bodymindarts bodymindarts force-pushed the tilt-dev branch 2 times, most recently from cf0ffaf to 4cdb27b Compare October 23, 2023 13:38
@github-actions github-actions bot added the core label Oct 24, 2023
@bodymindarts bodymindarts marked this pull request as ready for review October 25, 2023 14:56
@@ -0,0 +1,34 @@
#!/bin/bash
Copy link
Member

@nicolasburtey nicolasburtey Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make to look into terraform so we have some parity with prod, instead of having a script? or that would not make sense for dev?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO too much overhead to bring in another tool for dev.

Copy link
Contributor

@vindard vindard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Local workflows work, and I can see how we might tailor this to be able to run integration/bats test against soon

@@ -0,0 +1,19 @@
rpcuser=rpcuser
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intention to eventually remove these files from core/api/dev?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@bodymindarts bodymindarts merged commit 808208e into main Oct 26, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants