chore: fix dashboard bug for invalid token, added dev mode for captcha #3410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| geetest_validate: "mockValidate", | ||
| geetest_seccode: "mockSecCode", | ||
| } | ||
| const res = await sendPhoneCode(mockCaptchaResult, formData) |
There was a problem hiding this comment.
maybe I'm not understanding the code correctly, but there is no need to fetch the sendPhoneCode endpoint in dev mode, because no code is been sent.
the action should be as simple as moving to the next screen instead.
There was a problem hiding this comment.
In this, we are just sending mock data. I thought this would mimic production mode better, but yes, we can just redirect.
nicolasburtey
requested changes
Oct 24, 2023
siddhart1o1
force-pushed
the
chore--dashboard-bugs-added-dev-captcha
branch
2 times, most recently
from
0fc66eb to
4b36155
Compare
added 6 commits
October 27, 2023 14:52
…r captcha rebase rebase
rebase rebase
siddhart1o1
force-pushed
the
chore--dashboard-bugs-added-dev-captcha
branch
from
4b36155 to
e721a9e
Compare
nicolasburtey
approved these changes
Oct 27, 2023
siddhart1o1
added a commit
that referenced
this pull request
Oct 28, 2023
#3410) * chore: fix display dashboard bug for invalid token, added dev mode for captcha rebase rebase * chore: changes in captcha dev mode * chore: addressing comments rebase rebase * fix: next_auth_url port * fix; price notation for small amount * chore: misc chagnes --------- Co-authored-by: Siddharth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.