fix: error handling, dark mode, consent bug fixes #3408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddhart1o1
force-pushed
the
fix--consent-bugs
branch
from
e70c0f5 to
999599f
Compare
| <div className="flex justify-center mb-4"> | ||
| <Image src="/blink_logo.svg" alt="Galoy" width={120} height={120} /> | ||
| </div> | ||
| <svg |
There was a problem hiding this comment.
I think svg are best saved as .svg
siddhart1o1
force-pushed
the
fix--consent-bugs
branch
from
22111a6 to
f3d3377
Compare
| @@ -61,9 +70,41 @@ export const getCaptchaChallenge = async ( | |||
| } | |||
| } | |||
|
|
|||
| const res = await authApi.requestPhoneCaptcha(customHeaders) | |||
| let res | |||
There was a problem hiding this comment.
no implicit any
@vindard could we enforce this in the apps?
apps/consent/env.ts
Outdated
| @@ -8,10 +8,12 @@ export const env = createEnv({ | |||
| }, | |||
| shared: { | |||
| GRAPHQL_ENDPOINT: z.string().default("http://localhost:4002/graphql"), | |||
| NODE_ENV: z.string().default("development"), | |||
There was a problem hiding this comment.
cf comment on the other repo.
it's not ideal to have several PR open for review with code overlapping. it adds overhead for the reviewer.
siddhart1o1
force-pushed
the
fix--consent-bugs
branch
7 times, most recently
from
adb0b1c to
c258611
Compare
|
This PR will be split into smaller PRs. |
siddhart1o1
force-pushed
the
fix--consent-bugs
branch
2 times, most recently
from
4be5fa9 to
cdd55d4
Compare
added 5 commits
November 1, 2023 00:03
rebase rebase rebase rebase rebase rebase rebase rebase rebase
rebase rebase rebase
added 7 commits
November 1, 2023 00:04
siddhart1o1
force-pushed
the
fix--consent-bugs
branch
from
cdd55d4 to
5db3f44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.