feat: basic support for buck2 #3294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodymindarts
commented
Oct 4, 2023
|
|
||
| def npm_bin( | ||
| visibility = ["PUBLIC"], | ||
| node_modules = ":node_modules", |
There was a problem hiding this comment.
I have found a legit reason to have a macro wrapper. In the attrss ={} section above you can only specify a default target as a dependency that has an aboslute path (like toolchain//:simple_pnpm) not a relative one (like :node_modules which is in the same CELL).
Still no need to have completely other file just for this IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.