Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash on error in sessionPublicContext #3271

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

nicolasburtey
Copy link
Member

@nicolasburtey nicolasburtey commented Sep 27, 2023

  • I don't think it make sense to throw in the middleware
  • I don't think it make sense to wrap the error in mapError
  • passing the error to next when it arise.

@nicolasburtey nicolasburtey merged commit 7496429 into main Sep 27, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants