chore: setting ResourceAttemptsTimelockServiceError to warn instead o… #3265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vindard
reviewed
Sep 25, 2023
| @@ -81,7 +81,7 @@ export const idempotencyMiddleware = async ( | |||
| fallbackMsg: "Error locking idempotency key", | |||
| level: ErrorLevel.Critical, | |||
| }) | |||
| if (error instanceof ExecutionError) { | |||
There was a problem hiding this comment.
Do we still need the try-catch in the lines above this if we're (correctly) doing this inside the lock service now?
nicolasburtey
force-pushed
the
chore--setting-ResourceAttemptsTimelockServiceError-to-warn-instead-of-critical
branch
2 times, most recently
from
3c4b262 to
cd959bb
Compare
nicolasburtey
force-pushed
the
chore--setting-ResourceAttemptsTimelockServiceError-to-warn-instead-of-critical
branch
from
cd959bb to
9a65b06
Compare
nicolasburtey
force-pushed
the
chore--setting-ResourceAttemptsTimelockServiceError-to-warn-instead-of-critical
branch
from
9a65b06 to
dab8a0d
Compare
vindard
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…f critical