Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: poc for boltcard #3226

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

feat: poc for boltcard #3226

wants to merge 23 commits into from

Conversation

nicolasburtey
Copy link
Member

No description provided.

apps/boltcard/lnurlw.ts Fixed Show fixed Hide fixed
apps/boltcard/lnurlw.ts Fixed Show fixed Hide fixed
@nicolasburtey nicolasburtey force-pushed the feat--poc-for-boltcard branch 4 times, most recently from 7f8cec6 to b97b9a4 Compare September 16, 2023 18:40
@gitguardian
Copy link

gitguardian bot commented Sep 16, 2023

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
8153731 Generic High Entropy Secret fcc8fc4 apps/boltcard/new.ts View secret
8153731 Generic High Entropy Secret b99ceb7 apps/boltcard/new.ts View secret
8153731 Generic High Entropy Secret c4ac5c9 apps/boltcard/new.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

apps/boltcard/app/knex.ts Fixed Show fixed Hide fixed
@nicolasburtey nicolasburtey force-pushed the feat--poc-for-boltcard branch 2 times, most recently from e530e59 to 749b75d Compare September 21, 2023 13:24
apps/boltcard/services/db/card-init.ts Dismissed Show dismissed Hide dismissed
@nicolasburtey nicolasburtey force-pushed the feat--poc-for-boltcard branch 2 times, most recently from df54283 to ec62754 Compare October 6, 2023 08:51
@nicolasburtey nicolasburtey marked this pull request as ready for review October 18, 2023 19:04
@nicolasburtey nicolasburtey force-pushed the feat--poc-for-boltcard branch from b979b47 to 218fd2f Compare October 28, 2023 11:58
@github-actions github-actions bot added the core label Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant