Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger restart invoices issue #3186

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Conversation

dolcalmi
Copy link
Collaborator

@dolcalmi dolcalmi commented Sep 8, 2023

Uses similar strategy to setupPaymentSubscribe to avoid missing invoices when trigger is restarted/deployed

@dolcalmi dolcalmi force-pushed the fix-trigger-restart-invoices-issue branch from 8a908f6 to 619e67a Compare September 8, 2023 15:05
@dolcalmi dolcalmi requested a review from vindard September 8, 2023 15:06
@dolcalmi dolcalmi marked this pull request as draft September 8, 2023 15:47
@dolcalmi
Copy link
Collaborator Author

dolcalmi commented Sep 9, 2023

cron is declining usd invoices so this is not a solution

@dolcalmi dolcalmi closed this Sep 9, 2023
@nicolasburtey nicolasburtey reopened this Sep 14, 2023
@nicolasburtey nicolasburtey force-pushed the fix-trigger-restart-invoices-issue branch from 619e67a to b36c44a Compare September 14, 2023 08:58
@nicolasburtey nicolasburtey marked this pull request as ready for review September 14, 2023 08:58
@nicolasburtey
Copy link
Member

@dolcalmi I had revamped this PR expecting it would now pass with this PR merged a9f0a26, but it doesn't.

https://github.com/GaloyMoney/galoy/actions/runs/6183203185/job/16785119904?pr=3186

I'll let you dive into it

@nicolasburtey nicolasburtey force-pushed the fix-trigger-restart-invoices-issue branch from b36c44a to ceddf6e Compare September 14, 2023 13:30
@dolcalmi dolcalmi force-pushed the fix-trigger-restart-invoices-issue branch from ceddf6e to 2af1059 Compare September 18, 2023 14:15
@dolcalmi dolcalmi merged commit 8cc3416 into main Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants