chore: genericize prettier config and add to apps/dashboard (#3396)

* chore: genericise prettier config for apps/dashboard This helps with format-on-save linting in IDEs like VSCode. * chore: rename lib in .prettierignore * fix: .prettier.config.js file name * chore: add lint:fix script to dashboard * chore: add eslint_d for faster fixing --------- Co-authored-by: bodymindarts <[email protected]>
GaloyMoney · Oct 20, 2023 · abaaac7 · abaaac7
1 parent 58eb8d1
commit abaaac7
Show file tree

Hide file tree

Showing 9 changed files with 54 additions and 16 deletions.
diff --git a/apps/dashboard/.eslintrc.cjs → apps/dashboard/.eslintrc.js b/apps/dashboard/.eslintrc.cjs → apps/dashboard/.eslintrc.js
diff --git a/apps/dashboard/package.json b/apps/dashboard/package.json
@@ -6,7 +6,7 @@
     "dev": "next dev",
     "build": "next build",
     "start": "next start -p 3001",
-    "lint": "next lint",
+    "lint:fix": "eslint --fix --ext .ts,.tsx .",
     "codegen": "graphql-codegen --config codegen.yml"
   },
   "dependencies": {
@@ -42,6 +42,7 @@
     "@types/react-dom": "latest",
     "autoprefixer": "latest",
     "eslint": "latest",
+    "eslint_d": "latest",
     "eslint-config-next": "latest",
     "postcss": "latest",
     "tailwindcss": "latest",

diff --git a/apps/dashboard/prettier.config.cjs b/apps/dashboard/prettier.config.cjs
@@ -0,0 +1,3 @@
+const baseConfig = require("@galoy/eslint-config/prettier");
+
+module.exports = baseConfig
diff --git a/core/api/.prettierignore b/core/api/.prettierignore
@@ -1,5 +1,5 @@
 coverage
-lib
+dist
 tmp
 charts
 protos

diff --git a/lib/eslint-config/.eslintrc.base.js b/lib/eslint-config/.eslintrc.base.js
@@ -1,6 +1,8 @@
+const prettierConfig = require('./.prettier.config');
 const { execSync } = require('child_process');
 const actualProjectDir = execSync('npm prefix').toString().replace(/\n/g, '');
 
+
 module.exports = {
     env: {
       browser: true,
@@ -37,19 +39,7 @@ module.exports = {
 
       "prettier/prettier": [
         "error",
-        {
-          semi: false,
-          trailingComma: "all",
-          printWidth: 90,
-          quoteProps: "consistent",
-          singleQuote: false,
-          tabWidth: 2,
-          useTabs: false,
-          bracketSpacing: true,
-          arrowParens: "always",
-          proseWrap: "preserve",
-          endOfLine: "lf"
-        }
+        prettierConfig
       ],
 
       "arrow-body-style": "off",

diff --git a/lib/eslint-config/.prettier.config.js b/lib/eslint-config/.prettier.config.js
@@ -0,0 +1,16 @@
+module.exports = {
+  // Custom:
+  semi: false,
+  trailingComma: "all",
+  printWidth: 90,
+  quoteProps: "consistent",
+
+  // Defaults:
+  singleQuote: false,
+  tabWidth: 2,
+  useTabs: false,
+  bracketSpacing: true,
+  arrowParens: "always",
+  proseWrap: "preserve",
+  endOfLine: "lf",
+}
diff --git a/lib/eslint-config/BUCK b/lib/eslint-config/BUCK
@@ -7,6 +7,7 @@ filegroup(
     name = "src",
     srcs = [
         ".eslintrc.base.js",
+        ".prettier.config.js",
     ],
     visibility = ["PUBLIC"],
 )
diff --git a/lib/eslint-config/package.json b/lib/eslint-config/package.json
@@ -6,7 +6,8 @@
     "preinstall": "npx only-allow pnpm"
   },
   "exports": {
-    "./base": "./.eslintrc.base.js"
+    "./base": "./.eslintrc.base.js",
+    "./prettier": "./.prettier.config.js"
   },
   "devDependencies": {
     "@typescript-eslint/eslint-plugin": "^6.8.0",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		const baseConfig = require("@galoy/eslint-config/prettier");

		module.exports = baseConfig
-Original file line number
+Diff line change
@@ -1,5 +1,5 @@
     coverage
-    lib
+    dist
     tmp
     charts
     protos
@@ Expand Down @@