chore(core): enforce non-negative 'volumeRemaining' (#3628)

GaloyMoney · Nov 29, 2023 · a97b03b · a97b03b
1 parent b695d2f
commit a97b03b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/core/api/src/domain/accounts/limits-volume.ts b/core/api/src/domain/accounts/limits-volume.ts
@@ -77,7 +77,8 @@ export const AccountTxVolumeRemaining = (
       "txVolume.limitCheck": AccountLimitsType.IntraLedger,
     })
 
-    return calc.sub(limitAmount, outgoingUsdVolumeAmount)
+    const rawVolumeRemaining = calc.sub(limitAmount, outgoingUsdVolumeAmount)
+    return calc.max(ZERO_CENTS, rawVolumeRemaining)
   }
 
   const withdrawal = async ({
@@ -110,7 +111,8 @@ export const AccountTxVolumeRemaining = (
     })
 
     const netVolumeAmount = calc.sub(outgoingUsdVolumeAmount, incomingUsdVolumeAmount)
-    return calc.sub(limitAmount, netVolumeAmount)
+    const rawVolumeRemaining = calc.sub(limitAmount, netVolumeAmount)
+    return calc.max(ZERO_CENTS, rawVolumeRemaining)
   }
 
   const tradeIntraAccount = async ({
@@ -138,7 +140,8 @@ export const AccountTxVolumeRemaining = (
       "txVolume.limitCheck": AccountLimitsType.SelfTrade,
     })
 
-    return calc.sub(limitAmount, outgoingUsdVolumeAmount)
+    const rawVolumeRemaining = calc.sub(limitAmount, outgoingUsdVolumeAmount)
+    return calc.max(ZERO_CENTS, rawVolumeRemaining)
   }
 
   return {

diff --git a/core/api/test/unit/domain/accounts/limits-volume.spec.ts b/core/api/test/unit/domain/accounts/limits-volume.spec.ts
@@ -129,7 +129,7 @@ describe("LimitsChecker", () => {
     })
   })
 
-  describe.skip("returns 0n for walletVolumes above limit", () => {
+  describe("returns 0n for walletVolumes above limit", () => {
     it("intraLedger", async () => {
       const remaining = await volumeRemainingCalc.intraLedger({
         priceRatio,