refactor(core): continue if tx bundle is invalid

core/api/src/services/ledger/facade/update-state.ts

@@ -1,9 +1,12 @@
 import { Transaction } from "../books"
 import { NoTransactionToUpdateStateError, UnknownLedgerError } from "../domain/errors"
 
+import { recordExceptionInCurrentSpan } from "@/services/tracing"
+
 import { LnPaymentStateDeterminator } from "@/domain/ledger/ln-payment-state"
 
 import * as LedgerFacade from "@/services/ledger/facade"
+import { ErrorLevel } from "@/domain/shared"
 
 const updateStateByHash = async ({
   paymentHash,
@@ -30,7 +33,7 @@ export const updateLnPaymentState = async ({
 }: {
   walletIds: WalletId[]
   paymentHash: PaymentHash
-}): Promise<true | ApplicationError> => {
+}): Promise<boolean | ApplicationError> => {
   const txns = await LedgerFacade.getTransactionsForWalletsByPaymentHash({
     walletIds,
     paymentHash,
@@ -39,7 +42,19 @@ export const updateLnPaymentState = async ({
 
   const lnPaymentState = LnPaymentStateDeterminator(txns).determine()
   if (lnPaymentState instanceof Error) {
-    return lnPaymentState
+    recordExceptionInCurrentSpan({
+      error: lnPaymentState,
+      level: ErrorLevel.Critical,
+      attributes: {
+        ["error.actionRequired.message"]:
+          "Check the transaction bundle using the paymentHash and walletIds, " +
+          "determine the transaction state type, and manually update transactions " +
+          "with this has to the correct state.",
+        ["error.actionRequired.paymentHash"]: paymentHash,
+        ["error.actionRequired.walletIds"]: JSON.stringify(walletIds),
+      },
+    })
+    return false
   }
 
   const markedState = await updateStateByHash({