chore(api): unify separated no-implicit-any checks (#3559)

GaloyMoney · Nov 16, 2023 · 2ceaf4a · 2ceaf4a
1 parent b87bfcd
commit 2ceaf4a
Show file tree

Hide file tree

Showing 8 changed files with 4 additions and 26 deletions.
diff --git a/core/api/Makefile b/core/api/Makefile
@@ -108,10 +108,8 @@ integration-in-ci:
 unit-in-ci:
 	. ./.env && \
 		LOGLEVEL=warn $(BIN_DIR)/jest --config ./test/unit/jest.config.js --ci --bail --maxWorkers=50%
-check-implicit:
-	pnpm run tsc-check-noimplicitany
 
-check-code: check-implicit
+check-code:
 	pnpm run tsc-check
 	pnpm run eslint-check
 	pnpm run build

diff --git a/core/api/package.json b/core/api/package.json
@@ -1,7 +1,6 @@
 {
   "name": "api",
   "scripts": {
-    "tsc-check-noimplicitany": "tsc --noEmit -p tsconfig.no-implicit-any.json",
     "tsc-check": "tsc --noEmit",
     "madge-check": "madge --circular --extensions ts ./src",
     "madge-check-tests": "madge --circular --extensions ts ./test",

diff --git a/core/api/src/debug/websocket/package.json b/core/api/src/debug/websocket/package.json
@@ -2,7 +2,6 @@
   "name": "galoy",
   "type": "module",
   "scripts": {
-    "tsc-check-noimplicitany": "tsc --noEmit -p tsconfig.no-implicit-any.json",
     "tsc-check": "tsc --noEmit",
     "eslint-check": "eslint \"{src,test}/**/*.ts\"",
     "eslint-fix": "eslint \"{src,test}/**/*.ts\" --fix",

diff --git a/core/api/src/debug/websocket/tsconfig.json b/core/api/src/debug/websocket/tsconfig.json
@@ -5,7 +5,7 @@
       "sourceMap": true,
       "strict": true,
       "target": "es2020",
-      "noImplicitAny": false,
+      "noImplicitAny": true,
       "useUnknownInCatchVariables": false,
       "esModuleInterop": true,
       "baseUrl": "./",

diff --git a/core/api/tsconfig-build.json b/core/api/tsconfig-build.json
@@ -1,7 +1,4 @@
 {
   "extends": "./tsconfig.json",
-  "include": ["src/servers/**/*.ts", "src/**/*.d.ts"],
-  "compilerOptions": {
-    "noImplicitAny": true
-  }
+  "include": ["src/servers/**/*.ts", "src/**/*.d.ts"]
 }
diff --git a/core/api/tsconfig.d.json b/core/api/tsconfig.d.json
diff --git a/core/api/tsconfig.json b/core/api/tsconfig.json
@@ -8,6 +8,7 @@
     "esModuleInterop": true,
     "baseUrl": "./",
     "moduleResolution": "node",
+    "noImplicitAny": true,
     "resolveJsonModule": true,
     "paths": {
       "@/*": [

diff --git a/core/api/tsconfig.no-implicit-any.json b/core/api/tsconfig.no-implicit-any.json