build: genericize eslint and add to apps/dashboard tests (#3394)

* chore: switch build folder from 'lib' to 'dist' * test: setup generic eslint config structure with dashboard * build: add eslint rule to apps/dashboard * build: add check-lint to apps/dashboard test suite * chore: fix prettier lints * chore: fix 'import/order' lints * chore: fix '@typescript-eslint/no-unused-vars' lints * chore: fix 'no-duplicate-imports' lints * chore: fix 'import/no-unassigned-import' lints * chore: update pnpm lock file * build: add lib/eslint-config to root BUCK * fix: root BUCK * fix: export package-json from eslint-config BUCK --------- Co-authored-by: bodymindarts <[email protected]>
GaloyMoney · Oct 19, 2023 · 1739e6c · 1739e6c
1 parent f9c9869
commit 1739e6c
Show file tree

Hide file tree

Showing 48 changed files with 839 additions and 579 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,5 +1,5 @@
 ## Compiled JavaScript files
-lib/**/*.js
+dist/**/*.js
 **/*.js.map
 
 # Typescript v1 declaration files
@@ -26,7 +26,7 @@ public/*
 !public/logo.png
 
 coverage
-lib
+dist
 artifacts
 
 generated.gql

diff --git a/BUCK b/BUCK
@@ -5,7 +5,8 @@ pnpm_workspace(
   child_packages = [
     "//core/api:package.json",
     "//apps/consent:package.json",
-    "//apps/dashboard:package.json"
+    "//apps/dashboard:package.json",
+    "//lib/eslint-config:package.json"
   ],
   visibility = ["PUBLIC"],
 )
diff --git a/apps/dashboard/.eslintrc.cjs b/apps/dashboard/.eslintrc.cjs
@@ -0,0 +1,3 @@
+module.exports = {
+  "extends": ["next/core-web-vitals", "@galoy/eslint-config/base"]
+}
diff --git a/apps/dashboard/.eslintrc.json b/apps/dashboard/.eslintrc.json
diff --git a/apps/dashboard/BUCK b/apps/dashboard/BUCK
@@ -1,4 +1,10 @@
-load("@toolchains//workspace-pnpm:macros.bzl", "build_node_modules", "next_build", "next_build_bin")
+load(
+  "@toolchains//workspace-pnpm:macros.bzl",
+  "build_node_modules",
+  "next_build",
+  "next_build_bin",
+  "eslint"
+)
 
 export_file(
   name = "package.json",
@@ -33,7 +39,21 @@ next_build_bin(
     name = "dashboard",
 )
 
+dev_deps_srcs = {
+    "lib/eslint-config": "//lib/eslint-config:src",
+}
+
+eslint(
+    name = "check-lint",
+    srcs = [":src"] + glob([".eslint*"]),
+    extensions = [".ts", ".tsx"],
+    allow_warnings = True,
+    dev_deps_srcs = dev_deps_srcs,
+)
+
 test_suite(
     name = "test",
-    tests = [],
+    tests = [
+        ":check-lint",
+    ],
 )
diff --git a/apps/dashboard/app/api/auth/[...nextauth]/route.ts b/apps/dashboard/app/api/auth/[...nextauth]/route.ts
@@ -1,21 +1,23 @@
-import NextAuth, { AuthOptions } from "next-auth";
-import { fetchUserData } from "@/services/graphql/queries/me-data";
-import { env } from "@/env";
-import { ApolloQueryResult } from "@apollo/client";
-import { MeQuery } from "@/services/graphql/generated";
+import NextAuth, { AuthOptions } from "next-auth"
+
+import { ApolloQueryResult } from "@apollo/client"
+
+import { fetchUserData } from "@/services/graphql/queries/me-data"
+import { env } from "@/env"
+import { MeQuery } from "@/services/graphql/generated"
 
 declare module "next-auth" {
   interface Profile {
-    id: string;
+    id: string
   }
   interface Session {
-    sub: string | null;
-    accessToken: string;
-    userData: ApolloQueryResult<MeQuery>;
+    sub: string | null
+    accessToken: string
+    userData: ApolloQueryResult<MeQuery>
   }
 }
 
-const type = "oauth" as const;
+const type = "oauth" as const
 export const authOptions: AuthOptions = {
   providers: [
     {
@@ -32,7 +34,7 @@ export const authOptions: AuthOptions = {
       profile(profile) {
         return {
           id: profile.sub,
-        };
+        }
       },
     },
   ],
@@ -42,32 +44,32 @@ export const authOptions: AuthOptions = {
     async jwt({ token, account, profile }) {
       // Persist the OAuth access_token and or the user id to the token right after signin
       if (account) {
-        token.accessToken = account.access_token;
-        token.expiresAt = account.expires_at;
-        token.refreshToken = account.refresh_token;
-        token.id = profile?.id;
+        token.accessToken = account.access_token
+        token.expiresAt = account.expires_at
+        token.refreshToken = account.refresh_token
+        token.id = profile?.id
       }
-      return token;
+      return token
     },
-    async session({ session, token, user }) {
+    async session({ session, token }) {
       if (
         !token.accessToken ||
         !token.sub ||
         typeof token.accessToken !== "string" ||
         typeof token.sub !== "string"
       ) {
-        throw new Error("Invalid token");
+        throw new Error("Invalid token")
       }
 
-      const userData = await fetchUserData(token.accessToken);
-      session.sub = token.sub;
-      session.accessToken = token.accessToken;
-      session.userData = userData;
-      return session;
+      const userData = await fetchUserData(token.accessToken)
+      session.sub = token.sub
+      session.accessToken = token.accessToken
+      session.userData = userData
+      return session
     },
   },
-};
+}
 
-const handler = NextAuth(authOptions);
+const handler = NextAuth(authOptions)
 
-export { handler as GET, handler as POST };
+export { handler as GET, handler as POST }
diff --git a/apps/dashboard/app/layout.tsx b/apps/dashboard/app/layout.tsx
@@ -1,23 +1,24 @@
-import SessionProvider from "@/components/session-provider";
-import "./globals.css";
-import type { Metadata } from "next";
-import { authOptions } from "./api/auth/[...nextauth]/route";
-import Header from "@/components/header";
-import Sidebar from "@/components/side-bar";
-import { getServerSession } from "next-auth";
-import ThemeRegistry from "@/theme/theme-registry";
+import type { Metadata } from "next"
+import { getServerSession } from "next-auth"
+
+// eslint-disable-next-line import/no-unassigned-import
+import "./globals.css"
+
+import { authOptions } from "./api/auth/[...nextauth]/route"
+
+import Header from "@/components/header"
+import SessionProvider from "@/components/session-provider"
+import Sidebar from "@/components/side-bar"
+
+import ThemeRegistry from "@/theme/theme-registry"
 
 export const metadata: Metadata = {
   title: "Create Next App",
   description: "Generated by create next app",
-};
+}
 
-export default async function RootLayout({
-  children,
-}: {
-  children: React.ReactNode;
-}) {
-  const session = await getServerSession(authOptions);
+export default async function RootLayout({ children }: { children: React.ReactNode }) {
+  const session = await getServerSession(authOptions)
 
   return (
     <html lang="en">
@@ -39,5 +40,5 @@ export default async function RootLayout({
         </ThemeRegistry>
       </body>
     </html>
-  );
+  )
 }
diff --git a/apps/dashboard/app/loading.tsx b/apps/dashboard/app/loading.tsx
@@ -1,12 +1,12 @@
-import { CircularProgress } from "@mui/joy";
-import React from "react";
+import { CircularProgress } from "@mui/joy"
+import React from "react"
 
 function Loading() {
   return (
     <div className="flex justify-center items-center min-h-screen">
       <CircularProgress />
     </div>
-  );
+  )
 }
 
-export default Loading;
+export default Loading
diff --git a/apps/dashboard/app/page.tsx b/apps/dashboard/app/page.tsx
@@ -1,18 +1,19 @@
-import { getServerSession } from "next-auth";
-import { authOptions } from "./api/auth/[...nextauth]/route";
-import PriceContainer from "@/components/price-container/price-container";
-import ContentContainer from "@/components/content-container";
+import { getServerSession } from "next-auth"
+
+import { authOptions } from "./api/auth/[...nextauth]/route"
+
+import PriceContainer from "@/components/price-container/price-container"
+import ContentContainer from "@/components/content-container"
 
 export default async function Home() {
-  const session = await getServerSession(authOptions);
-  const walletDetails =
-    session?.userData?.data?.me?.defaultAccount?.wallets || [];
+  const session = await getServerSession(authOptions)
+  const walletDetails = session?.userData?.data?.me?.defaultAccount?.wallets || []
 
   return (
     <main>
       <ContentContainer>
         <PriceContainer walletDetails={walletDetails}></PriceContainer>
       </ContentContainer>
     </main>
-  );
+  )
 }
diff --git a/apps/dashboard/app/transactions/page.tsx b/apps/dashboard/app/transactions/page.tsx
@@ -1,47 +1,49 @@
-import { getServerSession } from "next-auth";
-import React from "react";
-import { authOptions } from "../api/auth/[...nextauth]/route";
-import TransactionDetails from "@/components/transaction-details/transaction-details-table";
-import ContentContainer from "@/components/content-container";
+import { getServerSession } from "next-auth"
+import React from "react"
+
+import { authOptions } from "../api/auth/[...nextauth]/route"
+
+import TransactionDetails from "@/components/transaction-details/transaction-details-table"
+import ContentContainer from "@/components/content-container"
 import {
   fetchFirstTransactions,
   fetchPaginatedTransactions,
-} from "@/services/graphql/queries/get-transactions";
-import TransactionCard from "@/components/transaction-details/transaction-card-item";
-import PageNumber from "@/components/transaction-details/page-number";
+} from "@/services/graphql/queries/get-transactions"
+import TransactionCard from "@/components/transaction-details/transaction-card-item"
+import PageNumber from "@/components/transaction-details/page-number"
 
 interface TransactionDetailsSearchParams {
-  cursor: string;
-  direction: "next" | "previous";
+  cursor: string
+  direction: "next" | "previous"
 }
 
 export default async function page({
   searchParams,
 }: {
-  searchParams: TransactionDetailsSearchParams;
+  searchParams: TransactionDetailsSearchParams
 }) {
-  const { cursor, direction } = searchParams;
-  const session = await getServerSession(authOptions);
-  const token = session?.accessToken;
+  const { cursor, direction } = searchParams
+  const session = await getServerSession(authOptions)
+  const token = session?.accessToken
   if (!token || typeof token !== "string") {
-    throw new Error("invalid token");
+    throw new Error("invalid token")
   }
 
-  const numberOfTransactions = 50;
-  let response;
+  const numberOfTransactions = 50
+  let response
   if (cursor && direction) {
     response = await fetchPaginatedTransactions(
       token,
       direction,
       cursor,
       numberOfTransactions,
-    );
+    )
   } else {
-    response = await fetchFirstTransactions(token, numberOfTransactions);
+    response = await fetchFirstTransactions(token, numberOfTransactions)
   }
 
-  const rows = response?.edges?.map((edge) => ({ node: edge.node })) ?? [];
-  const pageInfo = response?.pageInfo;
+  const rows = response?.edges?.map((edge) => ({ node: edge.node })) ?? []
+  const pageInfo = response?.pageInfo
   return (
     <ContentContainer>
       {rows.length > 0 ? (
@@ -54,5 +56,5 @@ export default async function page({
         <span>No Transactions Found</span>
       )}
     </ContentContainer>
-  );
+  )
 }
diff --git a/apps/dashboard/app/url.ts b/apps/dashboard/app/url.ts
@@ -1,9 +1,9 @@
 interface UrlInfo {
-  title: string;
-  protected: boolean;
+  title: string
+  protected: boolean
 }
 
 export const URLS: Record<string, UrlInfo> = {
   "/": { title: "Home", protected: true },
   "/transactions": { title: "Transactions", protected: true },
-};
+}