Add astropy.units support to config layer. #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmeyers314
force-pushed
the
quantity
branch
from
1cfd499 to
26b74b3
Compare
|
I think this is ready now. I added
I think there are a lot of places where this will particularly benefit ImSim. |
jmeyers314
force-pushed
the
quantity
branch
from
4c6308e to
0db480e
Compare
|
This is great Josh. FYI, here is an old imSim issue about this: |
rmjarvis
approved these changes
Sep 17, 2024
docs/config_values.rst
Outdated
| * A string interpretable by `astropy.units.Quantity` (e.g. '8.7 m') | ||
| * A dict with: | ||
|
|
||
| * ``type`` = *str* (required) There is only one valid option: |
There was a problem hiding this comment.
There seem to be two valid options.
There was a problem hiding this comment.
Looks like I mimicked the sky_value section, which also technically has two valid options. I'll fix that one too.
docs/config_values.rst
Outdated
| * A string interpretable by `astropy.units.Unit` (e.g. 'm') | ||
| * A dict with: | ||
|
|
||
| * ``type`` = *str* (required) There is only one valid option: |
jmeyers314
force-pushed
the
quantity
branch
from
031adb6 to
dc14a00
Compare
jmeyers314
force-pushed
the
quantity
branch
from
dc14a00 to
35de439
Compare
rmjarvis
added
notation/conventions
rmjarvis
added
the
desc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting to add astropy Quantity/Unit support to GalSim config layer... WIP, but could be worth a quick look at what's here so far.