Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't err if SiliconSensor accumulates on image outside range of treering function #1258

Merged
merged 4 commits into from
Nov 1, 2023

Conversation

rmjarvis
Copy link
Member

In ImSim, we sometimes make a stamp image that is large enough to extend past the allowed range of the treering function. The treatment outside that range is irrelevant, since we just ignore the part that is outside the bounds of the main image, but the current code was raising an exception.

This PR changes it to just ignore tree rings on any pixels that are outside the range of the treering function.

@rmjarvis rmjarvis added bug report Bug report desc Of possible interest to LSST DESC members looking for a project labels Oct 29, 2023
@rmjarvis rmjarvis added this to the v2.5 milestone Oct 29, 2023
@rmjarvis rmjarvis requested a review from jchiang87 October 29, 2023 02:35
@rmjarvis rmjarvis requested a review from jmeyers314 October 31, 2023 16:42
Copy link
Member

@jmeyers314 jmeyers314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmjarvis rmjarvis merged commit 4fbd662 into releases/2.5 Nov 1, 2023
10 checks passed
@rmjarvis rmjarvis deleted the treering_extrap branch November 1, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Bug report desc Of possible interest to LSST DESC members looking for a project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants