-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change in README file type and addition of installation README #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - great start! I have a few comments on the PR; I haven't actually looked at how the rst files appear but will go check it out now.
INSTALL.rst
Outdated
@@ -0,0 +1,34 @@ | |||
Installation Instructions | |||
================== | |||
GalSim-Euclid-Like is a python module implemented mainly in Python. It currently supports Python versions 3.10 and above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"is a python module implemented mainly in Python" reads a bit strange to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I agree, I am not sure if this is necessary information or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would simplify it to The GalSim-Euclid-Like repository contains two python libraries and currently supports Python versions 3.10 and above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed.
|
||
Attribution for software and data used by particular routines in this library is given in the docstring for the relevant routine. | ||
|
||
Installation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the idea is that we won't have an installation section in the README, but will simply point to the INSTALL.rst for instructions? If we leave it here then we have to always keep both versions up to date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to follow what GalSim does, which is have some basic installation instructions in the README and more in detail instructions in the INSTALL file. But it's a good point about having to keep both versions up to date.
Co-authored-by: Rachel Mandelbaum <[email protected]>
The README file type has been changed from
.md
to.rst
, in part for additional complexity provided by rst and in preparation for Sphinx integration. Installation readme has also been added.