Update Euclid-like PSF normalization to remove obscuration #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rmandelb
requested changes
Sep 26, 2024
Co-authored-by: Rachel Mandelbaum <[email protected]>
Co-authored-by: Rachel Mandelbaum <[email protected]>
rmandelb
approved these changes
Sep 26, 2024
rmandelb
reviewed
Sep 26, 2024
|
New test is exactly what I had in mind, thanks. |
Co-authored-by: Rachel Mandelbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PSF images provided are normalized for obscuration, vignetting and baffle effects. However,
GalSiminternally handles the obscuration, so we remove this part of the normalization by dividing the PSF images bycollecting_area / ((diameter/2)**2*np.pi).