Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates in preparation for making repo public #81

Merged
merged 7 commits into from
Sep 27, 2024
Merged

Conversation

rmandelb
Copy link
Member

@rmandelb rmandelb commented Sep 12, 2024

This is a start at repo updates needed before making the repo public, such as ensuring proper attributions for inputs and clear explanations in the README.

A few questions came up as I was going over the repo:

  • Do the installation instructions need to be updated? I realize there is the GalSim question but also not sure if these are correct for EuclidLike-imsim (Edit: there is a separate issue for installation instructions)
  • I noticed that the euclidlike-imsim directory includes a bunch of stuff related to SCAs (from filenames and using grep to see what is in the files). Are these residues of roman_imsim that should be cleaned up or removed?

@rmandelb rmandelb requested review from aguinot and andyyPark and removed request for aguinot September 25, 2024 01:28
@aguinot aguinot mentioned this pull request Sep 25, 2024
30 tasks
Copy link
Collaborator

@FedericoBerlfein FedericoBerlfein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

README.md Outdated Show resolved Hide resolved
@rmandelb rmandelb merged commit c7a55b2 into main Sep 27, 2024
2 checks passed
@rmandelb rmandelb deleted the u/rmandelb/dox branch September 27, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants