Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the pupil PSF to euclidlike_imsim (wait for #38 !!) #39

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

aguinot
Copy link
Collaborator

@aguinot aguinot commented Jul 24, 2024

This PR should be merge after #38 as it implements the method to imsim.

@aguinot aguinot added the enhancement New feature or request label Jul 24, 2024
@aguinot aguinot requested a review from FedericoBerlfein July 24, 2024 21:58
@FedericoBerlfein
Copy link
Collaborator

Just have to change the naming convention for the bright PSF so it matches the changes in #38. I have checked that the changes here + the changes in #38 allow you to run production when combined.

euclidlike_imsim/psf.py Outdated Show resolved Hide resolved
Update function name

Co-authored-by: FedericoBerlfein <[email protected]>
@aguinot aguinot merged commit f68cd9e into main Aug 7, 2024
2 checks passed
@aguinot aguinot deleted the axel/imsim_new_psf branch August 7, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants