Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to burn v13 and also add streaming mode #24

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

sudomonikers
Copy link

@sudomonikers sudomonikers commented Apr 4, 2024

Upgrade to burn v13 and add streaming mode

@antimora
Copy link

antimora commented May 2, 2024

Glad you're making these improvements and sharing them here with us. Hopefully this gets merged. Probably the PR description needs to be updated.

Another improvement could be made is to use Burn's PyTorchFileRecoder to load the model (I am the author of the recorder). The converter tool can load the pt file directly and save into Burn's format.

@sudomonikers
Copy link
Author

Glad you're making these improvements and sharing them here with us. Hopefully this gets merged. Probably the PR description needs to be updated.

Another improvement could be made is to use Burn's PyTorchFileRecoder to load the model (I am the author of the recorder). The converter tool can load the pt file directly and save into Burn's format.

Hi @DavidGOrtega ! I recently just merged this into the main branch of the fork i created. Although it is not the main repo maybe the fork will be helpful for some people. I updated the README to reflect the work I did so please lmk if you have any questions!

https://github.com/sudomonikers/whisper-burn

@sudomonikers sudomonikers changed the title Merge pull request #18 from DavidGOrtega/fix-17-Python-issues Upgrade to burn v13 and also add streaming mode May 6, 2024
@Quackdoc
Copy link

I am getting this issue when trying to run the pre-configed models, I am assuming that we need updated ones? If so can they be provided? installing tinygrad needs torch and this can all add up to be quite a lot, it was fine for me, but others maybe not so

mkdir -p models/tiny_en
cd models/tiny_en
wget https://huggingface.co/Gadersd/whisper-burn/resolve/main/tiny_en/tiny_en.cfg
wget https://huggingface.co/Gadersd/whisper-burn/resolve/main/tiny_en/tiny_en.mpk.gz
wget https://huggingface.co/Gadersd/whisper-burn/resolve/main/tiny_en/tokenizer.json
-> cargo run --release --bin stream tiny_en en
(next part has been formated with printf)

Failed to load whisper model file: Unknown("Unable to load record.
Metadata has a different int type: Actual \"f32\", Expected \"i32\"
Metadata has a different format: Actual \"burn_core::record::file::NamedMpkGzFileRecorder<burn_core::record::settings::FullPrecisionSettings>\", Expected \"burn_core::record::file::NamedMpkFileRecorder<burn_core::record::settings::FullPrecisionSettings>\"
Metadata has a different Burn version: Actual \"0.8.0\", Expected \"0.13.1\"
Error: Unknown(\"missing field `_b`\")")% 

@Gadersd
Copy link
Owner

Gadersd commented Oct 6, 2024

I hesitate to merge this pull request because the total size is 244 MB while the original is 523 KB. Can you reduce the size?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants