Return short hex string and change log

Signed-off-by: Gabriel-Trintinalia <[email protected]>
Gabriel-Trintinalia · Oct 27, 2023 · e72f6a1 · e72f6a1
1 parent 7568818
commit e72f6a1
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/.../hyperledger/besu/ethereum/api/jsonrpc/internal/methods/miner/MinerGetMinPriorityFee.java b/.../hyperledger/besu/ethereum/api/jsonrpc/internal/methods/miner/MinerGetMinPriorityFee.java
@@ -37,6 +37,6 @@ public String getName() {
   public JsonRpcResponse response(final JsonRpcRequestContext requestContext) {
     return new JsonRpcSuccessResponse(
         requestContext.getRequest().getId(),
-        miningParameters.getMinPriorityFeePerGas().toHexString());
+        miningParameters.getMinPriorityFeePerGas().toShortHexString());
   }
 }
diff --git a/.../hyperledger/besu/ethereum/api/jsonrpc/internal/methods/miner/MinerSetMinPriorityFee.java b/.../hyperledger/besu/ethereum/api/jsonrpc/internal/methods/miner/MinerSetMinPriorityFee.java
@@ -48,7 +48,8 @@ public JsonRpcResponse response(final JsonRpcRequestContext requestContext) {
       final Wei minPriorityFeePerGas =
           Wei.fromHexString(requestContext.getRequiredParameter(0, String.class));
       miningParameters.setMinPriorityFeePerGas(minPriorityFeePerGas);
-      LOG.debug("min priority fee per gas changed to {}", minPriorityFeePerGas);
+      LOG.debug(
+          "min priority fee per gas changed to {}", minPriorityFeePerGas.toHumanReadableString());
       return new JsonRpcSuccessResponse(requestContext.getRequest().getId(), true);
     } catch (final IllegalArgumentException invalidJsonRpcParameters) {
       return new JsonRpcErrorResponse(

diff --git a/...erledger/besu/ethereum/api/jsonrpc/internal/methods/miner/MinerGetMinPriorityFeeTest.java b/...erledger/besu/ethereum/api/jsonrpc/internal/methods/miner/MinerGetMinPriorityFeeTest.java
@@ -39,15 +39,15 @@ public void setUp() {
 
   @Test
   public void shouldReturnMinPriorityFee() {
-    Wei minPriorityFee = Wei.fromHexString("0x46");
+    String minPriorityFee = "0x46";
 
     final JsonRpcRequestContext request =
         new JsonRpcRequestContext(new JsonRpcRequest("2.0", method.getName(), new Object[] {}));
 
-    when(miningParameters.getMinPriorityFeePerGas()).thenReturn(minPriorityFee);
+    when(miningParameters.getMinPriorityFeePerGas()).thenReturn(Wei.fromHexString(minPriorityFee));
 
     final JsonRpcResponse expected =
-        new JsonRpcSuccessResponse(request.getRequest().getId(), minPriorityFee.toHexString());
+        new JsonRpcSuccessResponse(request.getRequest().getId(), minPriorityFee);
 
     final JsonRpcResponse actual = method.response(request);
     assertThat(actual).usingRecursiveComparison().isEqualTo(expected);