Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set render distance for mob inside mod spawner to 16 blocks #761

Merged
merged 5 commits into from
Dec 3, 2024

Conversation

Alexdoru
Copy link
Member

@Alexdoru Alexdoru commented Nov 29, 2024

Rendering the mob inside the spawners is a huge performance hit especially in the rog like dungeons where there are many spawners.

The default render distance is 64 blocks, I set the render distance for the spinning mob to 16.

image

@Dream-Master Dream-Master requested a review from a team December 1, 2024 21:23
@Alexdoru
Copy link
Member Author

Alexdoru commented Dec 2, 2024

Do you want me to add a slider in the video options menu? I feel like that's too much of a random option to have it show up in the video settings menu

@Ethryan
Copy link

Ethryan commented Dec 3, 2024

LGTM, but let’s wait for the main guy in charge (Mitch).

@mitchej123 mitchej123 merged commit 70d15f2 into master Dec 3, 2024
1 check passed
@mitchej123 mitchej123 deleted the spawner-render branch December 3, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants