update code style

Relates #21
GSG-G9 · Feb 10, 2021 · e7c9815 · e7c9815
1 parent 89c75b2
commit e7c9815
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 10 deletions.
diff --git a/server/controllers/kindergartens/kindergartenSearch.js b/server/controllers/kindergartens/kindergartenSearch.js
@@ -13,15 +13,7 @@ const kindergartenSearch = async (req, res, next) => {
       abortEarly: false,
     });
 
-    if (!q && (!minPrice || !maxPrice) && !locationId) {
-      next(
-        boomify(
-          400,
-          'Validation Error',
-          'At least one of these (q, minPrice & maxPrice,locationId) values is required'
-        )
-      );
-    } else {
+    if (q || (minPrice && maxPrice) || locationId) {
       const { rows: data } = await getKindergartenSearch({
         q,
         minPrice,
@@ -33,6 +25,14 @@ const kindergartenSearch = async (req, res, next) => {
         StatusCode: 200,
         data,
       });
+    } else {
+      next(
+        boomify(
+          400,
+          'Validation Error',
+          'At least one of these (q, minPrice & maxPrice,locationId) values is required'
+        )
+      );
     }
   } catch (error) {
     next(

diff --git a/test/search.test.js b/test/search.test.js
@@ -90,7 +90,6 @@ describe('search endPoint', () => {
       }));
 
   test('Route /search?minPrice=500&maxPrice=1000, status 200, json header, data = testData', (done) => {
-    // still something TODO
     const testData = {
       id: 6,
       kindergarten_name: 'روضة الزهراء النموذجية الخاصة',