Changing conformance criteria roll up count from a list to a table #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Just the new drupal files * delete old acr * delete old acr * pre-commit fixes --------- Co-authored-by: pre-commit <[email protected]>
* Update drupal-10-16.yaml Changing the path to CivicActions. * Update drupal-10-16.html Using the CLI * Moving the 16 Simple * Adding Drupal 10 16 Simple * pre-commit fixes * Updated Drupal 10 yaml version. --------- Co-authored-by: pre-commit <[email protected]> Co-authored-by: Daniel Mundra <[email protected]>
* Redoing progressPerChapter to output counts as a table. * Removed skipping of none label. * Adjusted table counts per row display. * Added functions to get level and component labels to use in the progress table. * Updating markdown examples after testing. Reset output functions. * Changed any column header to all and added margin to simple table. * Removed un-needed conditional check. * Added check for undefined and updated all examples. * Added test when first criteria has missing components. Updated output logic and regenerated examples. * Updated tests. * Updated version and ran JS build.
|
Check failure reasons:
|
drewnielson
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharing some changes we made last year to the output of the ACR. Instead of the roll-up of conformance to be a list, it is a table. See https://civicactions.github.io/openacr/drupal-10-16.html#success_criteria_level_a and here is an example:
Previously:
Conformance to the 30 criteria listed below is distributed as follows:
After the changes:
Conformance to the 30 criteria listed below is distributed within each category as follows:
Also updating the stored examples with the above changes and latest ACR for Drupal.