Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WCAG 2.2 and EN 301 549 data, update to VPAT 2.5, refactor Librarian #353

Merged
merged 6 commits into from
Mar 12, 2024

Conversation

patrickhlauke
Copy link
Contributor

@patrickhlauke patrickhlauke commented Dec 29, 2023

  • add new /catalog/data/wcag-2.2.yaml to include all new SCs (note: keeps 4.1.1 as it is still reportable)
  • add new /catalog/data/en-301-549.yaml (using as starting point the data that was already added by hand to /catalog/2.4-edition-wcag-2.1-508-eu-en.yaml)
  • update terms and any references to VPAT version number to new ITI VPAT 2.5 https://www.itic.org/policy/accessibility/vpat
  • refactor Librarian utility (and associated createCatalog) to better handle combining an arbitrary amount (array) of standards
  • add support for VPAT 2.5 INT (the only version not supported yet is the pure EU version, as this will require re-numbering of chapters in final document - this should be done as one big separate update that runs at the end over the combined output and makes sure chapter numbers are properly sequential)
  • add generated yaml files for all the catalog variants the Librarian now supports (note: left the previous 2.4 versions in place...this may require further planning/thinking on how these old versions should be maintained or generated ... perhaps librarian needs an extra version switch for VPAT too?)

* add new `/catalog/data/wcag-2.2.yaml` to include all new SCs (note: keeps 4.1.1 as it is still reportable)
* add new `/catalog/data/en-301-549.yaml` (using the data that was already added by hand to `/catalog/2.4-edition-wcag-2.1-508-eu-en.yaml`
* update terms and any references to VPAT version number to new ITI VPAT 2.5 https://www.itic.org/policy/accessibility/vpat
* refactor Librarian utility (and associated `createCatalog`) to better handle combining an arbitrary amount (array) of standards
* add support for VPAT 2.5 INT (the only version not supported yet is the pure EU version, as this will require re-numbering of chapters in final document - this should be done as one big separate update that runs at the end over the combined output and makes sure chapter numbers are properly sequential)
* add generated yaml files for all the catalog variants the Librarian now supports (note: left the previous 2.4 versions in place...this may require further planning/thinking on how these old versions should be maintained or generated ... perhaps librarian needs an extra version switch for VPAT too?)
@patrickhlauke patrickhlauke marked this pull request as draft December 29, 2023 22:24
seems the original source for this, `/catalog/2.4-edition-wcag-2.1-508-eu-en.yaml`, had a few oddities/mistakes
@patrickhlauke patrickhlauke marked this pull request as ready for review December 29, 2023 22:53
@patrickhlauke
Copy link
Contributor Author

Note that this may need more work in other parts of the project - I focused purely on the /catalog and related Librarian generation parts

@patrickhlauke patrickhlauke marked this pull request as draft December 30, 2023 01:51
@patrickhlauke patrickhlauke marked this pull request as ready for review December 30, 2023 02:02
@thibaudcolas
Copy link

For what it’s worth – I tried updating my report based on 2.4-edition-wcag-2.1-508-eu-en.yaml to the new 2.5 edition WCAG 2.2 here, it worked great 🌈. All I had to do was manually add the data for the additional SCs in my YAML report, then use the CLI with this PR to output Markdown and HTML. Thank you!

@patrickhlauke
Copy link
Contributor Author

patrickhlauke commented Jan 6, 2024

thanks for checking, @thibaudcolas - admittedly, I made this PR "cold" without actually trying it out. I do suspect this will require some work on related projects like https://github.com/GSA/openacr-editor

additionally, note that unfortunately for the EU standard, it seems there's only a PDF version officially available, so the alt_id references are made-up and don't actually point back to the relevant section in the PDF. not sure if these should therefore just be left blank, or changed to reference just the #page=... number for the PDF (as is the case in the official ITI VPAT when it comes to the EU links), or something else...

…g 2.4.13 criteria to wcag2.2 data, regenerated catalogs. Small code cleanup and updated package files.
@dmundra
Copy link
Collaborator

dmundra commented Feb 19, 2024

@patrickhlauke I submitted a PR to these changes by forking your repo patrickhlauke#1, it should fix the tests and make a few modifications.

Updated catalog and librarian tests for the new changes.
@patrickhlauke
Copy link
Contributor Author

@dmundra merged your PR into my branch, which I can see updated the PR here

@drewnielson drewnielson merged commit 76250c2 into GSA:main Mar 12, 2024
4 of 5 checks passed
@patrickhlauke patrickhlauke deleted the wcag2.2 branch March 12, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants