Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Templating GammaCalculator over deriv_t type #252

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Templating GammaCalculator over deriv_t type #252

wants to merge 12 commits into from

Conversation

the-florist
Copy link
Member

Changes:

  • Made the GammaCalculator class a templated class over deriv_t type, in the style of the MatterCCZ4RHS class.
  • Put the instantiations of the GammaCalculator class in the initialData functions of KerrBHLevel, ScalarFieldLevel and ApparentHorizonFinder3DTestLevel, in logic statements that change the template type based on the requested order of derivatives, as for the MatterCCZ4RHS class.
  • Note that the ApparentHorizonFinder instance of GammaCalculator was commented out, and that although I have altered these lines, I have left them commented out.

the-florist added 12 commits May 1, 2024 13:25
@the-florist
Templated GammaCalculator over m_deriv
744cbda 
Made the necessary changes to GammaCalculator.hpp to template over
m_deriv, and implemented the choice over max_spatial_derivative_order
in ScalarFieldLevel.cpp/InitialData.
@the-florist
Altered KerrBHLevel and ApparentHorizonFinderTest
c7f5885 
Added the choice over max_spatial_derivative_order and new templated
format for GammaCalculator to the KerrBH example (InitialData) and
ApparentHorizonFinderTest3DLevel.hpp InitialData function (still
commented out).
@the-florist
Fixed clang formatting
802672f 
In GammaCalculator and ScalarFieldLevel, which the auto
tests for pushing to the repo complained about.
@the-florist
Fixed clang formatting
a81c481 
In GammaCalculator and ScalarFieldLevel, which the auto
tests for pushing to the repo complained about.
@the-florist
Merge branch 'bugfix/GammaCalculator_deriv_template' of github.com:th…
59a19a5 
…e-florist/GRC_workspace into bugfix/GammaCalculator_deriv_template
@the-florist
Another formatting fix
cc83fad
@the-florist
Reset params output_path variable to be blank
1aacb88
@the-florist
Reset params output_path variable to be blank
42539ff
@the-florist
Merge branch 'bugfix/GammaCalculator_deriv_template' of github.com:th…
0fe22d9 
…e-florist/GRC_workspace into bugfix/GammaCalculator_deriv_template
@the-florist
Merge branch 'bugfix/GammaCalculator_deriv_template' of github.com:th…
d223f44 
…e-florist/GRC_workspace into bugfix/GammaCalculator_deriv_template
@the-florist
Commented out output_path in SF params
90a6923
@the-florist
Merge branch 'bugfix/GammaCalculator_deriv_template' of github.com:th…
ca0477d 
…e-florist/GRC_workspace into bugfix/GammaCalculator_deriv_template
@mirenradia mirenradia linked an issue May 3, 2024 that may be closed by this pull request
4th order derivative stencils hard-coded in GammaCalculator class #251
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4th order derivative stencils hard-coded in GammaCalculator class
1 participant
@the-florist