Second seminar #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sss4920
commented
Apr 9, 2023
sss4920
commented
- article데이터 형식 정의 & article dto 정의
- 게시물 생성 실습
- Arraylist의 get 메서드를 이용해 Path Variable로 getOneById 작성
- Query Parameter로 searchOneByTitle 작성
dragontaek-lee
approved these changes
Apr 10, 2023
| return "게시물이 존재하지 않습니다."; | ||
|
|
||
| } | ||
| public String searchByArticleId(Long article_id){ |
There was a problem hiding this comment.
별거는 아닐수 있지만, SpringBoot에서는 package, 파일명 등.. 카멜케이스를 많이 쓰고는 해요. (articleId)
그리고 userId는 카멜케이스로 썼기 때문에 통일감이 있으면 더 좋을거 같아요!
There was a problem hiding this comment.
허억 그렇군요ㅋㅋ 수정해보겠습니다!
| // 저장한 유저 아이디 값 반환 | ||
| return newArticle.getId(); | ||
| } | ||
| public String searchByArticleTitle(String title){ |
There was a problem hiding this comment.
stream()을 활용하면 더 간결하고 멋진 코드가 될거 같아요!
제가 직접 돌려보지는 않아서 맞을지는 모르겠어요. 한번 검색해 보시고 적용해보시면 나중에도 많이 쓰이니 좋을거 같아요!
Optional<Article> article = articleList.stream()
.filter(a -> a.getTitle().equals(title))
.findFirst();
return article.map(a -> "id=" + a.getId() + "\n title=" + a.getTitle() + "\n text=" + a.getText())
.orElse("게시물이 존재하지 않습니다.");
There was a problem hiding this comment.
우와 이런 방법이 있군요... 람다를 더 공부해봐야겠네요..! (코드 리뷰하러 와서 배워가는 사람)
There was a problem hiding this comment.
헉 저도 저렇게 구현하는 방법이 있을 줄 몰랐어요! 위 코드에 모르는게 좀 많아서..ㅎ 좀 더 공부해보고 이해가 완벽히 되면 바꿔 올리겠습니다!
|
수정까지 완벽해요!! 많이 배워갑니다!😄 |
|
허걱 감사합니다!!🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.