Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality of life improvements for SV inspector #4682

Merged
merged 8 commits into from
Nov 26, 2024
Merged

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Nov 26, 2024

this is a refactor of the spreadsheet view and sv-inspector view to support some new features including:

Ability to inspect more types of SVs

previously, our code was a bit over-fitted to translocations/breakend spec VCF files, and plain old things like deletions would not even be rendered

now it will show any feature, and if they just have a start and end, it draws an arc from the start to the end. this will let deletions, inversions, etc get displayed. even snps are given an arc if you open a snp track. not sure if that's useful, but it is a thing.

Re-navigates existing popped out breakpoint split views from sv inspector

previously, created a new one every time which meant it was hard to 'flip through' a bunch of variants

Add ability to open a track from your tracklist as a dataset in sv inspector

previously, you had to manually open a file by URL or from your computer. now it gives you the option to open files from your tracklist

Doesn't persist data in session if a URL is opened, allowing larger files to be used

it will just refetch the file when you refresh the page, rather than putting it in your session, which only works for smaller files

Uses @mui/x-data-grid

I removed all our spreadsheet code and used x-data-grid. it is just a well done grid component

Backwards compatible with old session snapshots

We can still open up old session snapshots. This is good because #4047 which was sort of similar to this PR got a bit lost in refactoring and didn't end up being able to load old snapshots

VCF INFO split into multiple columns

the INFO field contains lots of interesting metadata that can be sorted filtered individually by giving each subsection it's own data grid column

#788

Potential breakages or losses of functionality

  • No more BreakpointSplitView.snapshotFromBreakendFeature. Instead import from @jbrowse/sv-core
  • No more multi-way sort, the x-data-grid is single sort
  • Uses structuredClone into the codebase, which has relatively good browser capability but requires a jest polyfill
  • Different internal data structures
  • No more CSV/TSV import. Could be recapitulated if needed

Screenshots

Grid

now
image

before
image

Import form

new, showing the simple "track selector" on the import form

image

@cmdcolin cmdcolin force-pushed the spreadsheet_datagrid branch 2 times, most recently from 327e86d to 447dbd3 Compare November 26, 2024 00:50
@cmdcolin
Copy link
Collaborator Author

Ability to re-navigate existing popped out breakpoint split views from sv inspector

this quality of life improvement i think is really good...previously it was quite challenging to 'flip through' variants but with this it is quite a bit easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant