Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GC-content track regression in v2.17.0 #4670

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Fix GC-content track regression in v2.17.0 #4670

merged 2 commits into from
Nov 19, 2024

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Nov 19, 2024

Fixes #4668

Swapped renderProps for adapterProps.

The adapterProps concept was added to make it so only adapter level things need to get sent to the adapter getFeatures (e.g. track height doesn't need to get sent to the data adapters unless for some esoteric case)

@cmdcolin cmdcolin added the bug Something isn't working label Nov 19, 2024
@cmdcolin cmdcolin merged commit e3522a8 into main Nov 19, 2024
4 checks passed
@cmdcolin cmdcolin deleted the fix_gc branch November 19, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCContent track empty in v2.17.0
1 participant