Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce self-pairing for some paired-end read data in breakpoint split view #4667

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Nov 19, 2024

some paired end BAM files, e.g. from GIAB have a weird thing where there is a duplication of the reads at each position. There is no BAM flag indicating it is a duplicate, so there's no real way to distinguish these. Our Breakpoint split view tries to connect features that have the same QNAME (read name) to match pairs (pairs share the same read name) but this weird duplicate reads also share the same QNAME.

This PR filters makes it so paired end reads specifically don't connect with features at the same position

before

image

after

image

focus on the 'problematic reads'

I filtered out just one qname which shows that it matches 4 boxes...typically it should be two (left and right side of pair) and any other matches to the qname should at least be distinguished by something but these aren't

https://jbrowse.org/code/jb2/main/?config=test_data%2Fconfig_demo.json&session=share-8ybk_-VNx0&password=5ww3R

image

all four of those boxes share the same QNAME

@cmdcolin cmdcolin merged commit 9a83551 into main Nov 19, 2024
4 checks passed
@cmdcolin cmdcolin deleted the reduced_self_pairing branch November 19, 2024 13:58
@cmdcolin cmdcolin changed the title Reduce self-pairing for weird paired-end BAM files Reduce self-pairing for some paired-end read data in breakpoint split view Nov 19, 2024
@cmdcolin cmdcolin added the bug Something isn't working label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant