Fix alignment curves showing up in inkscape for breakpoint svg (#4293)

GMOD · Mar 14, 2024 · 4287adb · 4287adb
1 parent 1dc2c32
commit 4287adb
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 10 deletions.
diff --git a/plugins/breakpoint-split-view/src/BreakpointSplitView/components/AlignmentConnections.tsx b/plugins/breakpoint-split-view/src/BreakpointSplitView/components/AlignmentConnections.tsx
@@ -59,13 +59,8 @@ const AlignmentConnections = observer(function ({
     yOffset = rect.top
   }
 
-  if (!assembly) {
-    return null
-  }
-
-  return (
+  return assembly ? (
     <g
-      stroke={theme.palette.text.disabled}
       fill="none"
       data-testid={layoutMatches.length ? `${trackId}-loaded` : trackId}
     >
@@ -133,6 +128,7 @@ const AlignmentConnections = observer(function ({
             <path
               d={path}
               key={id}
+              stroke={theme.palette.text.disabled}
               data-testid="r1"
               strokeWidth={mouseoverElt === id ? 5 : 1}
               onClick={() => {
@@ -160,7 +156,7 @@ const AlignmentConnections = observer(function ({
         return ret
       })}
     </g>
-  )
+  ) : null
 })
 
 export default AlignmentConnections
diff --git a/...ts/jbrowse-web/src/tests/__image_snapshots__/breakpoint_split_view_snapshot.svg b/...ts/jbrowse-web/src/tests/__image_snapshots__/breakpoint_split_view_snapshot.svg
diff --git a/products/jbrowse-web/src/tests/__snapshots__/BreakpointSplitView.test.tsx.snap b/products/jbrowse-web/src/tests/__snapshots__/BreakpointSplitView.test.tsx.snap
@@ -4,16 +4,17 @@ exports[`breakpoint split view 1`] = `
 <g
   data-testid="pacbio_hg002_breakpoints-loaded"
   fill="none"
-  stroke="rgba(0, 0, 0, 0.38)"
 >
   <path
     d="M 407.99312656000257 75.5 C 607.9931265600026 75.5 203.41868021525443 84.5 403.4186802152544 84.5"
     data-testid="r1"
+    stroke="rgba(0, 0, 0, 0.38)"
     stroke-width="1"
   />
   <path
     d="M 660.4186802152544 84.5 C 860.4186802152544 84.5 206.99312656000257 48.5 406.99312656000257 48.5"
     data-testid="r1"
+    stroke="rgba(0, 0, 0, 0.38)"
     stroke-width="1"
   />
 </g>

diff --git a/products/jbrowse-web/src/tests/__snapshots__/ExportSvgBreakpointSplitView.test.tsx.snap b/products/jbrowse-web/src/tests/__snapshots__/ExportSvgBreakpointSplitView.test.tsx.snap