Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Azure and GCP Clusters #9

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Enable Azure and GCP Clusters #9

merged 2 commits into from
Dec 29, 2023

Conversation

OpenGLShaders
Copy link
Contributor

  • Add Metadata attribute
  • Refactor ClusterDataSourceModel and ClusterResourceModel into a shared ClusterModel
  • Add correct Taints for Cluster Resource

@OpenGLShaders OpenGLShaders self-assigned this Dec 29, 2023
ikegentz
ikegentz reviewed Dec 29, 2023
View reviewed changes
internal/provider/cluster_data_source.go
values = append(values, ip)
}
strs, _ := types.ListValue(types.StringType, values)
return types.ObjectValue(map[string]attr.Type{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find on this 😎 . Can you add a note to our doc vault about it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! done

ikegentz
ikegentz approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@ikegentz ikegentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@OpenGLShaders OpenGLShaders merged commit 858b234 into main Dec 29, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikegentz ikegentz ikegentz approved these changes

Assignees

@OpenGLShaders OpenGLShaders

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OpenGLShaders @ikegentz