Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Remaining Deployment Variables #13

Merged
merged 8 commits into from
Jan 7, 2024
Merged

Add Remaining Deployment Variables #13

merged 8 commits into from
Jan 7, 2024

Conversation

OpenGLShaders
Copy link
Contributor

@OpenGLShaders OpenGLShaders commented Jan 4, 2024 •
edited
Loading

Changes: is_dag_deploy_enforced -> is_dag_deploy_enabled

Adds: environment_variables and task_pod_node_pool_id variables

Closes #12

@OpenGLShaders OpenGLShaders self-assigned this Jan 4, 2024
@OpenGLShaders OpenGLShaders marked this pull request as draft January 4, 2024 04:40
@OpenGLShaders OpenGLShaders requested a review from ikegentz January 7, 2024 00:03
@OpenGLShaders OpenGLShaders marked this pull request as ready for review January 7, 2024 15:02
ikegentz
ikegentz approved these changes Jan 7, 2024
View reviewed changes
Copy link
Contributor

@ikegentz ikegentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's update the minor version for the next release due to the variable name change

@ikegentz ikegentz merged commit fe057e9 into main Jan 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikegentz ikegentz ikegentz approved these changes

Assignees

@OpenGLShaders OpenGLShaders

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deployment Environment Variables Not Respected
2 participants
@OpenGLShaders @ikegentz