Adjusted some limits and dependencies in variables.csv #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added unit test for processing wind speed
We only of 1 digits precision measurments from out instantaneous values. This violates the bufr schema which expects 2 digits precision.
OOL contains dependent variables (children) * Added unit test functions for clip_values * Add a helper class, DependencyGraph, for modelling the dependency relations to find the children closure and handle circular dependencies. * Updated clip_values to set children variables to nan whenever a parent is nan. * Fixed a bug in clipValues introduced in commit d1a6ac8, where child variables were not set to nan due to an erroneous change in variable names. Fixed variables.csv * Removed incorrect OOL relations from variables.csv. wspd_x_u, wspd_y_u... had wdir and wspd as children. The relation is the opposite. * Removed double quotes around ool * Removed comma between ool entries in wspeed
* The rh corrected clipping were asigning 0 to inpu nan * Added unit test specifically for rh corr
|
OOL and variable dependencies were not working properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.