Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding zlib compression to netcdf #301

Merged
merged 7 commits into from
Nov 24, 2024

Conversation

BaptisteVandecrux
Copy link
Member

No description provided.

@BaptisteVandecrux BaptisteVandecrux changed the base branch from feature/adding-10min-values-in-hourly-files to develop September 11, 2024 09:15
@BaptisteVandecrux BaptisteVandecrux force-pushed the feature/adding-compression-to-netcdf branch from 10a19af to b0ae4e0 Compare November 13, 2024 12:57
BaptisteVandecrux and others added 7 commits November 21, 2024 14:18
Due to compression the the time required two read both hourly and 10 min data  (tested at this line) increases to 1.3 s. Now putting it to 5 s max before an error is raised.
* Made the NetCDF zip compression optional
* Only using compression on the final joined_l3 output
I couldn't see any usages of writeArr, writeL2 and writeL3 in the repository.
@ladsmund ladsmund force-pushed the feature/adding-compression-to-netcdf branch from 33a3655 to bf82a09 Compare November 21, 2024 13:18
Copy link
Contributor

@ladsmund ladsmund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I have added a the zlib compression as a flag to avoid applying on the intermediate files

@BaptisteVandecrux BaptisteVandecrux merged commit 89665a5 into develop Nov 24, 2024
3 checks passed
@BaptisteVandecrux BaptisteVandecrux deleted the feature/adding-compression-to-netcdf branch November 24, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants