Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/correct persistent qc #281

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Conversation

ladsmund
Copy link
Contributor

@ladsmund ladsmund commented Aug 8, 2024

  • Updated persistence.py to use explicit variable thresholds. Avoided applying the persistence filter on averaged pressure variables (p_u and p_l) due to their 0 decimal precision often leading to incorrect filtering.
  • Fixed bug in persistence QC where initial repetitions were ignored
  • Relocated unit persistence tests
  • Added explicit test for get_duration_consecutive_true
  • Renamed duration_consecutive_true to get_duration_consecutive_true for imperative clarity

Avoided applying the persistence filter on averaged pressure variables (`p_u` and `p_l`) due to their 0 decimal precision often leading to incorrect filtering.
* Relocated unit persistence tests
* Added explicit test for `get_duration_consecutive_true`
* Renamed `duration_consecutive_true` to `get_duration_consecutive_true` for imperative clarity
@ladsmund ladsmund merged commit 37527b1 into develop Aug 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants