Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/smoothing and extrapolating gps coordinates #268
Feature/smoothing and extrapolating gps coordinates #268
Changes from 1 commit
77004ab
94d7f93
2251a20
29a7bde
fe8f11d
5e02f5e
537d88f
5c452b3
d96246c
d6d1735
f66251f
8e32b9c
55b5f3a
d86384f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how this function can cause duplicated indices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because for each iteration/segment we select:
pypromice/src/pypromice/process/L2toL3.py
Line 422 in f66251f
which includes the timestamps of both breaks. So at one iteration the end break received an estimated value, and in the next iteration/segment that same break is a start break ad receives another value.
We therefore need to drop duplicates at the end.
I'm changing to
keep='last'
so that if a time stamp is a break, then it received the value estimated within the segment where it is a start break (and not an end break).