-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/restructure tests #265
Conversation
1e682ae
to
792d121
Compare
792d121
to
3519686
Compare
Why is the test module outside of |
I've just opened a PR to this branch #'270, just to update the function naming conventions in e2e. |
The tests are located outside the package to maintain a clear separation of concerns. This way, the I am open for discussion, but these are my current thoughts. |
I thought the test datasets were pretty light-weight, so do not make the package particularly bulky.
I think this will be useful (to us, and general users) especially now we have the bufr processing tests in here, as the eccodes bindings can sometimes not install correctly. Running the unit tests within the pypromice installation in say, a docker image, would be really useful. Let's discuss more next time we talk |
- Moved test modules and data from the package directory to the root-level tests directory. - Updated directory structure to ensure clear separation of source code and tests. - Updated import statements in test modules to reflect new paths. - Restructured the tests module: - Renamed original automatic tests to `e2e` as they primarily test the main CLI scripts. - Added `unit` directory for unit tests. - Created `data` directory for shared test data files. This comprehensive refactoring improves project organization by clearly separating test code from application code. It facilitates easier test discovery and enhances maintainability by following common best practices.
8be1933
to
4a98e48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @ladsmund!
Refactored and Organized Test Modules
- Renamed original automatic tests to
e2e
as they primarily test the main CLI scripts.- Added
unit
directory for unit tests.- Created
data
directory for shared test data files.This comprehensive refactoring improves project organization by clearly separating test code from application code. It facilitates easier test discovery and enhances maintainability by following common best practices.