Renamed static_qc -> persistent_qc #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PennyHow
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Looks good to me @ladsmund. I just edited the .github/workflows/unit_test.yml as the persistence QC test file name hadn't been updated. The PR checks all pass now.
I also updated the version number in setup.py from v1.2.1 to v1.3.0 as I deem the addition of the auto QCing a minor update (rather than a bug patch).
When you merge this branch then we need to make a new release in order for this to be published to pypi. Please let me know when you merge this - I'm happy to make the new release - I will also proceed with updating the conda-forge feedstock (here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.