Features/various cleanup #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladsmund
force-pushed
the
features/various_cleanup
branch
from
4c68745 to
e4487a7
Compare
Added logging handler configuration to getL3
ladsmund
force-pushed
the
features/various_cleanup
branch
from
e4487a7 to
ae572fe
Compare
The columns "msg_lat" and "mgs_lon" where explicitly added in AWS.__init__.
L0toL1, L1toL2 and L2toL3 functions are imported using absolute module paths as installed by the setup.py.
* Use separate module to avoid circular imports when used in other modules. * Renamed according to PEP8 https://peps.python.org/pep-0008/#function-and-variable-names
There is a slight change in the behaviour because the clipping and variable filtering happens on each individual L1 dataset before the merge. This will not have any impacts on the output and makes MergeVars superfluous.
ladsmund
force-pushed
the
features/various_cleanup
branch
from
ae572fe to
684f2bf
Compare
PennyHow
requested changes
Sep 27, 2023
There was a problem hiding this comment.
Generally looks great, just need that stray optional variable changing.
Once this is merged then I would like to do some additional clean-up. I see some functions do not follow conventional naming and like I said, I would like to move functions out of aws.py.
PennyHow
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made a selection of minor changes and cleaning in the code.
I am focussing on moving data functionality for data level transformation to the functions
toL1,toL2andtoL3instead of having some mutation inAWS. Let me know in the discussion if this is not a good idea.The responsibilities of
AWSare generally unclear for me and I think we should have a discussion about the structure and direction of this repository.Here are some header describing this PR:
toL1andtoL2instead ofAWS.