Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update use_v3 list in wmo_config.py #181

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Conversation

patrickjwright
Copy link
Collaborator

In response to Robert's email:

We made some updates to the PROMICE AWSs:

QAS_M decommissioned, replaced by QAS_Mv3
QAS_U decommissioned, but we have QAS_Uv3
NUK_U decommissioned, but we have NUK_Uv3
There is a new KAN_Lv3

All four of these stations should be in stid_to_skip['use_v3'].

For review, any station listed in stid_to_skip will be skipped in getBUFR. However, if we are processing a v3 station (e.g. NUK_Uv3) and the "base" station name (e.g. NUK_U) is listed in stid_to_skip['use_v3'] then we will process the v3 station and strip the v3 from the name so we are submitting to WMO with the registered non-v3 name.

The discontinued list is used for stations that have been discontinued and do not have a v3 and non-v3 version.

If @ladsmund will be maintaining the AWS processing and WMO BUFR generation moving forward, it is important to know about wmo_config.py and make sure it is periodically reviewed and maintained, particularly the stid_to_skip dict.

@patrickjwright
Copy link
Collaborator Author

After approval, this change should be put into production at Azure by pulling down the changes and updating the pypromice package.

src/pypromice/postprocess/wmo_config.py Outdated Show resolved Hide resolved
PennyHow
PennyHow previously approved these changes Sep 12, 2023
Copy link
Member

@PennyHow PennyHow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with NUK_U added to the v3 list. We hope to go and visit the station on Monday to resolve the issues with the station tilt not being recorded.

@ladsmund ladsmund merged commit 52a0d1e into main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants