Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fv namelist entry for AIST work #535

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Nov 6, 2023

This PR adds a new fv namelist entry for the AIST work by @tclune. To be used first GEOS-ESM/GFDL_atmos_cubed_sphere#83GFDL_atmos_cubed_sphere geos/v2.7.0 must be used.

There is a corresponding PR in FV3 (GEOS-ESM/FVdycoreCubed_GridComp#258) for the FV3 Standalone

By default, we add the flag as .false. which is zero-diff to current behavior. Enabling it will be non-zero-diff.


ETA: Now that GFDL_atmos_cubed_sphere geos/v2.7.0 is out and in GEOSgcm main (GEOS-ESM/GEOSgcm#696), this can go in.

@mathomp4 mathomp4 added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs labels Nov 6, 2023
@mathomp4 mathomp4 marked this pull request as ready for review November 9, 2023 13:19
@mathomp4 mathomp4 requested a review from a team as a code owner November 9, 2023 13:19
@mathomp4 mathomp4 removed the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Nov 9, 2023
@sdrabenh sdrabenh merged commit 703b455 into develop Nov 9, 2023
6 checks passed
@sdrabenh sdrabenh deleted the feature/tclune/#81-compute-coords-locally branch November 9, 2023 14:33
@mathomp4 mathomp4 restored the feature/tclune/#81-compute-coords-locally branch November 9, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants