Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out daily output #63

Merged
merged 6 commits into from
Feb 8, 2024
Merged

Comment out daily output #63

merged 6 commits into from
Feb 8, 2024

Conversation

sanAkel
Copy link
Collaborator

@sanAkel sanAkel commented Feb 7, 2024

Resolves #62

Coarse resolution diag_table is left untouched, since it used for debugging/development.

Commenting out `forcing` and `prog_z`
Commenting out `forcing` and `prog_z`
@sanAkel sanAkel requested a review from a team as a code owner February 7, 2024 17:54
Copy link

github-actions bot commented Feb 7, 2024

Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found:

@sanAkel sanAkel added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Feb 7, 2024
@sanAkel sanAkel self-assigned this Feb 7, 2024
@yvikhlya
Copy link

yvikhlya commented Feb 7, 2024

May I suggest to make them monthly instead of commenting out? We need ocean diagnostics in coupled runs, right?

Add back `prog_z` but make it monthly
Add back `prog_z` but make it monthly
@sanAkel
Copy link
Collaborator Author

sanAkel commented Feb 7, 2024

May I suggest to make them monthly instead of commenting out? We need ocean diagnostics in coupled runs, right?

Done.

@yvikhlya
Copy link

yvikhlya commented Feb 7, 2024

@sanAkel One last thing, did you leave dailies for sfc_ave intentionally?

@sanAkel
Copy link
Collaborator Author

sanAkel commented Feb 7, 2024

@sanAkel One last thing, did you leave dailies for sfc_ave intentionally?

yes @yvikhlya Let's have those daily 2d fields for now.

@yvikhlya
Copy link

yvikhlya commented Feb 8, 2024

Ok.

@yvikhlya yvikhlya merged commit 549a07e into develop Feb 8, 2024
9 checks passed
@yvikhlya yvikhlya deleted the sanAkel-patch-1 branch February 8, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daily collections for high resolutions
2 participants