Skip to content

Commit

Permalink
Refactor OGCM IS_FCST to OGCM_IS_FCST
Browse files Browse the repository at this point in the history
Testing by @sanAkel and @rtodling found that `IS_FCST` was a resource parameter in both the AGCM Grid Comp and in the DataSea and DataIce Grid Comps that was doing different things. In the DataSea and DataIce Grid Comps, it determined persistence of SST/ICE via `MAPL_ReadForcing`. But in the AGCM, it altered IAU handling (I think?).

Either way, there was no good way to set one without setting the other. So, for separability, we rename all the oceanic `IS_FCST` to be `OGCM_IS_FCST`. We keep the AGCM `IS_FCST` as it currently is named unless there is a desire to refactor it from @sdrabenh or others.
  • Loading branch information
mathomp4 committed Feb 27, 2024
1 parent 620a8cc commit 9c7456f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion GEOSdatasea_GridComp/GEOS_DataSeaGridComp.F90
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ subroutine RUN ( GC, IMPORT, EXPORT, CLOCK, RC )
! In atmospheric forecast mode we do not have future SST and SSS
!--------------------------------------------------------------

call MAPL_GetResource(MAPL,IFCST, LABEL="IS_FCST:", default=0, _RC)
call MAPL_GetResource(MAPL,IFCST, LABEL="OGCM_IS_FCST:", default=0, _RC)
call MAPL_GetResource(MAPL,adjSST,LABEL="SST_ADJ_UND_ICE:",default=0, _RC)

FCST = IFCST==1
Expand Down
4 changes: 2 additions & 2 deletions MIT_GEOS5PlugMod/configs/c12_cs32_01/AGCM.rc
Original file line number Diff line number Diff line change
Expand Up @@ -507,9 +507,9 @@ DIURNAL_BIOMASS_BURNING: yes
ANALYSIS_OX_PROVIDER: PCHEM # options: PCHEM, GMICHEM, STRATCHEM, GOCART


# Flag for real-time forecasts (persisted SST) IS_FCST: 1 (AMIP-Style Default: 0)
# Flag for real-time forecasts (persisted SST) OGCM_IS_FCST: 1 (AMIP-Style Default: 0)
# -------------------------------------------------------------------------------
IS_FCST: 0
OGCM_IS_FCST: 0


# Time step for aerosol assimilation (GAAS)
Expand Down
4 changes: 2 additions & 2 deletions MIT_GEOS5PlugMod/instructions/example_scripts/AGCM.rc
Original file line number Diff line number Diff line change
Expand Up @@ -819,9 +819,9 @@ DIURNAL_BIOMASS_BURNING: yes
ANALYSIS_OX_PROVIDER: PCHEM # options: PCHEM, GMICHEM, STRATCHEM, GOCART


# Flag for real-time forecasts (persisted SST) IS_FCST: 1 (AMIP-Style Default: 0)
# Flag for real-time forecasts (persisted SST) OGCM_IS_FCST: 1 (AMIP-Style Default: 0)
# -------------------------------------------------------------------------------
IS_FCST: 0
OGCM_IS_FCST: 0


# Time step for aerosol assimilation (GAAS)
Expand Down

0 comments on commit 9c7456f

Please sign in to comment.