Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

just first contribution #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

harsh-1981145
Copy link

Hello
I am Harsh Patel
I have added my name by chance and wanna pull it back with this request

@paramsiddharth
Copy link
Member

Please add a space before the # symbol. :)

@harsh-1981145
Copy link
Author

harsh-1981145 commented Nov 24, 2022 via email

Copy link
Member

@paramsiddharth paramsiddharth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harsh-1981145 Here you go!

@@ -0,0 +1 @@
#Harsh Patel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#Harsh Patel
# Harsh Patel

@harsh-1981145
Copy link
Author

harsh-1981145 commented Nov 27, 2022 via email

@paramsiddharth
Copy link
Member

i got the idea of required suggestion but can you explain the procedure for editing pull request cuz i tried but getting more and more confused

On Thu, 24 Nov 2022 at 15:55, Param Siddharth @.> wrote: @.* requested changes on this pull request. @harsh-1981145 https://github.com/harsh-1981145 Here you go! ------------------------------ In 221B171.md <#52 (comment)> : > @@ -0,0 +1 @@ +#Harsh Patel ⬇️ Suggested change -#Harsh Patel +# Harsh Patel — Reply to this email directly, view it on GitHub <#52 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3LK5GBCM36QS4AC4HSB4M3WJ47CJANCNFSM6AAAAAASHZHVRM . You are receiving this because you were mentioned.Message ID: @.***>

@harsh-1981145 For that, we'll need to do a meeting. :) We'll plan one with the entire GDSC and let you know. Watch the WhatsApp group for updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants