[Feature] 멘토 페이지 스터디 통계 조회 기능 생성 #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugene028
requested review from
ghdtjgus76,
hamo-o and
SeieunYoo
as code owners
SeieunYoo
reviewed
Dec 23, 2024
apps/admin/app/studies/[studyId]/_components/statics/StudyAssignmentRate.tsx
Outdated
Show resolved
Hide resolved
apps/admin/app/studies/[studyId]/_components/statics/StudyAttendanceRate.tsx
Outdated
Show resolved
Hide resolved
apps/admin/app/studies/[studyId]/_components/statics/graph/BarGraph.tsx
Outdated
Show resolved
Hide resolved
|
@SeieunYoo 코드리뷰 반영했습니다! 🙂 |
hamo-o
approved these changes
Dec 30, 2024
packages/ui/src/components/index.ts
Outdated
There was a problem hiding this comment.
p2;
툴팁 css가 적용이 안되어서 pnpm generate:css-file 한번 해주셔야 할 것 가타용
There was a problem hiding this comment.
앗 요건 몰랐네요! 챙겨두었습니다~
apps/admin/app/studies/[studyId]/_components/statics/graph/BarGraph.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
23
to
25
| const toggleTooltip = () => { | ||
| if (isToolTipActive) setShowTooltip((prevState) => !prevState); | ||
| }; |
There was a problem hiding this comment.
p3;
제 화면에서는 마우스가 벗어나도 토글이 적용되지 않는 이슈가 있었습니다..! 이후에는 토글이 반대로 적용되네요 ㅠ ㅠ
onMouseEnter될 때는 setShowTooltip(true) 해주고, onMouseLeave될 때는 setShowTooltip(false) 해주는 것이 안전해 보여요
There was a problem hiding this comment.
확인했습니다~ 꼼꼼하게 확인해주셔서 감사해요~! 🫡
soulchicken
reviewed
Dec 30, 2024
apps/admin/app/studies/[studyId]/_components/statics/graph/BarGraph.tsx
Outdated
Show resolved
Hide resolved
apps/admin/app/studies/[studyId]/_components/statics/graph/CircleGraph.tsx
Outdated
Show resolved
Hide resolved
|
@hamo-o @soulchicken 리뷰 반영 완료했습니당~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 변경 사항
멘토 페이지에 스터디 통계를 조회할 수 있는 그래프를 생성했어요.
간단한 UI 작업이지만 코드 관련해서 정리해야 할 부분 위주로 간단하게 확인해주시면 감사드리겠습니다!
🚩 관련 이슈
🙏 여기는 꼭 봐주세요!
지난 주 회의에서 휴강 관련한 통계 처리가 필요하다고 요청드린 부분까지 반영하였습니다!
확인하려면 피그마 링크 들어가시면 볼 수 있어요!