Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] 마이페이지 수료내역 api 연동 #166

Merged
merged 5 commits into from
Jan 5, 2025
Merged

[Feat] 마이페이지 수료내역 api 연동 #166

merged 5 commits into from
Jan 5, 2025

Conversation

SeieunYoo
Copy link
Collaborator

🎉 변경 사항

  • 마이페이지 수료내역 api 를 연동합니다.
  • 와디 테이블 컴포넌트를 활용해 마크업

🚩 관련 이슈

🙏 여기는 꼭 봐주세요!

image

  • 원래 디자인은 커스텀 테이블인데 와디의 테이블 컴포넌트를 활용하여 만들었습니다.

eugene028
eugene028 approved these changes Dec 29, 2024
View reviewed changes
Copy link
Collaborator

@eugene028 eugene028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스크린샷 2024-12-29 오후 6 36 38

먼가 피그마상의 UI로 봤을때는 표가 가로로 100% 차있어야 할 것 같아서 이부분 확인해주시면 감사드리겠습니당!

apps/client/app/(afterLogin)/my-page/_components/CompletedStudy.tsx Outdated Show resolved Hide resolved
hamo-o
hamo-o approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@hamo-o hamo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!! UI 관련 코멘트만 있어서 미리 어프룹합니당

apps/client/app/(afterLogin)/my-page/_components/CompletedStudy.tsx Show resolved Hide resolved
apps/client/app/(afterLogin)/my-page/_components/CompletedStudy.tsx Outdated Show resolved Hide resolved
@SeieunYoo
Copy link
Collaborator Author

image

리뷰 전부 반영했습니다!! 테이블 행 위의 여백도 조금 부족해 보여서 추가했습니다

+) Table.Td 컴포넌트에 className 으로 스타일을 추가하려고 하니까 기존에 존재하던 스타일이 전부 reset 되더라구요!
image
여기서 prop 을 통해서 받은 새로운 className 을 기존에 존재하는 className 과 합치지 않고 rest 로 넘겨서 발생하는 문제인 거 같아요~ 다른 컴포넌트들에서도 rest prop 으로 className 을 넘기는 로직이 있을 거 같아 디자인 시스템 컴포넌트에서 개선되면 좋을 거 같아요 cc. @eugene028

@SeieunYoo SeieunYoo requested a review from soulchicken as a code owner January 5, 2025 09:26
@SeieunYoo SeieunYoo merged commit 402a744 into dev Jan 5, 2025
1 check passed
@SeieunYoo SeieunYoo deleted the feat/mypage-api-completedStudy branch January 5, 2025 09:34
@SeieunYoo SeieunYoo mentioned this pull request Jan 5, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamo-o hamo-o hamo-o approved these changes

@eugene028 eugene028 eugene028 approved these changes

@ghdtjgus76 ghdtjgus76 Awaiting requested review from ghdtjgus76

@soulchicken soulchicken Awaiting requested review from soulchicken soulchicken is a code owner

Assignees

@SeieunYoo SeieunYoo

Labels
👩‍💻 리뷰 남겨주세요! 📝클라이언트 클라이언트 페이지 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] 마이 페이지 수료내역 api 연결 및 ui 구현
3 participants
@SeieunYoo @eugene028 @hamo-o