Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] 실패하는 테스트코드 정상화 (#43) #44

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

win-luck
Copy link
Contributor

#️⃣ 연관 이슈

📝 작업 내용

실패하고 있는 테스트코드를 정상화했습니다.

참고 이미지 및 자료

💬 리뷰 요구사항

@win-luck win-luck added fix 버그 및 에러 수정 test 테스트코드 labels Aug 30, 2024
@win-luck win-luck self-assigned this Aug 30, 2024
@win-luck win-luck linked an issue Aug 30, 2024 that may be closed by this pull request
Copy link
Contributor Author

@win-luck win-luck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI 파이프라인에서만 테스트가 실패하고 있어 구체적인 조사 후 추가 조치 예정입니다.

run: ./gradlew test
run: ./gradlew clean test --info --stacktrace
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

현재 로컬에선 성공하나 CI 파이프라인에서 테스트가 실패하고 있어, 원인 분석을 위해 로깅을 붙였습니다.

Comment on lines 34 to +53
@Autowired
private MockMvc mockMvc;
MockMvc mockMvc;

@MockBean
PhotoService photoService;

@MockBean
JpaMetamodelMappingContext jpaMetamodelMappingContext;

@MockBean
private PhotoService photoService;
JwtProvider jwtProvider;

@MockBean
private JpaMetamodelMappingContext jpaMetamodelMappingContext;
PuangUserArgumentResolver puangUserArgumentResolver;

@MockBean
private JwtProvider jwtProvider;
RateLimiterInterceptor rateLimiterInterceptor;

@MockBean
private PuangUserArgumentResolver puangUserArgumentResolver;
LettuceBasedProxyManager lettuceBasedProxyManager;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

불필요한 private을 제거하고 일부 의존성을 추가했습니다.

@win-luck win-luck merged commit 7a36676 into GDSC-CAU:main Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 버그 및 에러 수정 test 테스트코드
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test] 실패하는 테스트코드 정상화 (#43)
1 participant