[fix] auth의 누락된 예외 처리 및 Response Code 구체화 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tthisag246
requested review from
win-luck,
pjw-redt,
alsrudrl1220 and
RumosZin
win-luck
approved these changes
Aug 30, 2024
Comment on lines
46
to
48
| // 카카오 인증 서버로부터 카카오 ID 토큰 공개키 목록 조회하여 캐싱 | ||
| @Cacheable(key = "'all'") | ||
| public KakaoIDTokenPublicKeyList getOIDCPublicKeyList() { |
There was a problem hiding this comment.
추후 캐싱 Redis에 위임하셔도 좋을 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관 이슈
📝 작업 내용
참고 이미지 및 자료
💬 리뷰 요구사항